Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(reorganizing): break up geocoding package into multiple files #217

Merged
merged 2 commits into from
Jun 12, 2018
Merged

refactor(reorganizing): break up geocoding package into multiple files #217

merged 2 commits into from
Jun 12, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Jun 12, 2018 •
edited
Loading

  • reorganized the geocoding package for easier 📖 🤓ing
  • simplified the internal logic of bulkGeocode()
  • refactored to only throw an error when an anonymous bulk geocoding request is made to our hosted service and added a corresponding test.

AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder

ISSUES CLOSED: #216

@jgravois
refactor(reorganizing): break up geocoding package into multiple files
216f23c 
AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder

ISSUES CLOSED: #216
@coveralls
Copy link

coveralls commented Jun 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 99.325% when pulling 4acd4d1 on patch216 into 78f5faf on master.

@jgravois jgravois merged commit 0cc7aaa into master Jun 12, 2018
@jgravois jgravois deleted the patch216 branch June 12, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwayson tomwayson tomwayson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgravois @coveralls @tomwayson